Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog box for Windows #9

Closed
ObiWanTwo opened this issue Jan 14, 2019 · 6 comments
Closed

Dialog box for Windows #9

ObiWanTwo opened this issue Jan 14, 2019 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@ObiWanTwo
Copy link

Currently Jellyfin Theater electron does not have a dialog box in order to close/minimize the app.
It would really be nice to have that otherwise it's really hard to move the client around.

@lachlan-00
Copy link

looks like a frameless window?
https://electronjs.org/docs/api/frameless-window

main.js has the frame set to false.

var windowOptions = {
            transparent: false, //supportsTransparency,
            frame: false,
            resizable: false,
            title: 'Jellyfin Theater',
            minWidth: 720,
            minHeight: 480,
            //alwaysOnTop: true,
skipTaskbar: isWindows() ? false : true,

@lachlan-00
Copy link

Linux has pretty easy windows manipulation without a decoration but i can see windows people getting frustrated unless they use Win + arrows or a separate tool like AltWindowsDrag

@lachlan-00
Copy link

lachlan-00 commented Jan 15, 2019

Setting frame to true at least gets you a window decoration but the size for me is forced so i can't maximise.
image

@ghost
Copy link

ghost commented Jan 15, 2019

Many users have complained about this, I belive though (not quite sure) that the original intention of this app was to be for a home theater pc so it would just load up on something like a raspberry pi or something light weight. Once i finish perfecting this i will setup a little windowed version for desktops and such. Sorry for the inconvenience.

Later i will post how you can hack the code and change it to windowed mode your self if you would like,

@ObiWanTwo
Copy link
Author

Since the repo of jellyfin theater for windows is empty I used the electron version. Now that you stated the purpose of the app I understand better why this feature is lacking.
I will stick with @lachlan-00's solution for now.
Thank you for your answers!

@cromefire
Copy link
Contributor

Duplicate of #11

@anthonylavado anthonylavado added duplicate This issue or pull request already exists and removed enhancement New feature or request good first issue Good for newcomers labels May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Development

No branches or pull requests

4 participants