New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(subs): add styling to subtitles #1587

Merged

ThibaultNocchi merged 1 commit into master from feature/sub_style

Nov 4, 2021

Member

ThibaultNocchi commented Nov 4, 2021 •

edited

Won't work until jellyfin/jellyfin#6777

jellyfin-bot added this to In progress in Ongoing development

jellyfin-bot added the vue label


          feat(subs): add styling to subtitles

fdb97fe

ThibaultNocchi force-pushed the feature/sub_style branch from 930c4c5 to fdb97fe Compare

November 4, 2021 14:55

cloudflare-pages bot commented Nov 4, 2021 •

edited

Deploying with Cloudflare Pages

Latest commit:	`fdb97fe`
Status:	🚫 Build failed.

codecov bot commented Nov 4, 2021 •

edited

Codecov Report

Merging #1587 (fdb97fe) into master (5cf94ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1587   +/-   ##
=======================================
  Coverage   53.58%   53.58%           
=======================================
  Files          24       24           
  Lines         879      879           
  Branches      155      155           
=======================================
  Hits          471      471           
  Misses        400      400           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf94ea...fdb97fe. Read the comment docs.

sonarcloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

ferferga approved these changes

View reviewed changes

Ongoing development automation moved this from In progress to Reviewer approved

ThibaultNocchi merged commit 40b9689 into master

Ongoing development automation moved this from Reviewer approved to Done

ThibaultNocchi deleted the feature/sub_style branch

November 4, 2021 15:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment