feat(search): add search

[heyhippari]

It searches.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[heyhippari]

Converted back to draft, as it needs additional UI design, since I'm not happy with the way this looks.

[ferferga]

This probably should be in it's own discussion thread but:

What about renaming "People" tab to whatever category those "People" fall in? Just like current web, where they appear as "Artists" and "People".

Imo, we should have three categories:

• Artists
• Cast & Crew
• People

Although we don't have this feature yet, we shouldn't mix people's faces from photo libraries with the ones of movies/music/TV Shows.

I don't know how this is currently implemented but we don't have to add tabs when there are no items that match the query, so this shouldn't increase the UI's weight.

Again, this is completely unnecessary to do right now, but I think it's better if we do it this way since the beginning, instead of getting users "accostumed" to it later.

[Nickbert7]

I don't know if it is difficult to add, but would it be possible also include tags into the search?

[codecov-io]

Codecov Report

Merging #345 (91c231d) into master (9ad6a54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   53.41%   53.41%           
=======================================
  Files          24       24           
  Lines         863      863           
  Branches      151      151           
=======================================
  Hits          461      461           
  Misses        390      390           
  Partials       12       12           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad6a54...91c231d. Read the comment docs.

[ferferga]

Maybe we should replace the skeleton loader while searching with a spinning circle? There's a lot of jumpiness when searching for music, for instance.

[heyhippari]

Maybe we should replace the skeleton loader while searching with a spinning circle? There's a lot of jumpiness when searching for music, for instance.

I'm thinking about getting rid of the loader entirely, actually.

I think we should be able to combine asyncData and fetch to handle fetching information, as well as debouncing the search input to prevent it from triggering a search request on each input change.

This should make the experience a little better.

[ferferga]

@camc314 In case you want to take over this PR, I remember MrTimscampi mentioned that he wanted to follow this design for this: #522

If not, I can take a look at it this weekend maybe.

[camc314]

@camc314 In case you want to take over this PR, I remember MrTimscampi mentioned that he wanted to follow this design for this: #522

If not, I can take a look at it this weekend maybe.

Ah that design there looks good. All I have done, is rebased and moved some of the type fixings to a separate PR

[camc314]

@ferferga I've got it to a good enough state to be reviewed, any improvements based on the discussion can be done at a later date imo.

[ThibaultNocchi]

@camc314 I got errors loading the home page, I'm trying to see what it is

TypeError: String.prototype.search called on incompatible undefined
    _render vue-i18n.esm.js:1605
    _interpolate vue-i18n.esm.js:1511
    _translate vue-i18n.esm.js:1731
    _t vue-i18n.esm.js:1756
    $t vue-i18n.esm.js:233
    render default.vue:188
    VueJS 30
    NuxtJS 4
    Babel 18
    NuxtJS 2
    Babel 12
    NuxtJS 11
client.js:97
    _callee$ NuxtJS
    Babel 8
    VueJS 32
    NuxtJS 4
    Babel 18
    NuxtJS 2
    Babel 12
    NuxtJS 11

TypeError: String.prototype.search called on incompatible undefined
    _render vue-i18n.esm.js:1605
    _interpolate vue-i18n.esm.js:1511
    _translate vue-i18n.esm.js:1731
    _t vue-i18n.esm.js:1756
    $t vue-i18n.esm.js:233
    render default.vue:188
    VueJS 13
    SET_USER_VIEWS userViews.ts:36
    wrappedMutationHandler vuex.esm.js:844
    commitIterator vuex.esm.js:466
    commit vuex.esm.js:465
    _withCommit vuex.esm.js:624
    commit vuex.esm.js:464
    boundCommit vuex.esm.js:409
    commit vuex.esm.js:796
    _callee$ userViews.ts:52
    Babel 10
    wrappedActionHandler vuex.esm.js:851
    dispatch vuex.esm.js:516
    boundDispatch vuex.esm.js:406
    dispatch vuex.esm.js:779
    mappedAction vuex.esm.js:1064
    beforeMount default.vue:183
    VueJS 18
client.js:97

Edit: lmao he doesn't like the localization in the placeholder, which is already similarly used in master

Edit 2: he doesn't like search.search but accepts save for instance

Edit 3: guess what, it's because I'm in French and in the locale file there's no search object, only the current string. So ofc it crashes trying to access a property of a string :p

[ThibaultNocchi]

Suggested change

	"search": "search",
	"search": "Search",

IMO, it's weird not having this capitalized

[ThibaultNocchi]

So I pushed the needed changes for the locales, we'll have to check before merging if no other new "search" strings were added and add them to our PR if it is

[camc314]

I don't think we should be changing strings in other locale files. It should be done on weblate. In prod, it shouldn't cause an issue, just produce an error in the console

[ferferga]

Search doesn't work outside the main page, so you can't search if you're browsing a library, for instance.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

No longer relevant, prevents merging

[heyhippari]

@jellyfin-bot rebase

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication