-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(audio controls): improve responsiveness of audio controls #554
Conversation
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
======================================
Coverage 5.29% 5.29%
======================================
Files 104 104
Lines 2851 2851
Branches 428 428
======================================
Hits 151 151
Misses 2693 2693
Partials 7 7
Continue to review full report at Codecov.
|
Maybe not for this PR but what about moving shuffle, repeat, stop and such (not volume slider of course) to the item menu? I think that would be the best solution. |
I think skipping, and play/pausing are commands that are most likely to be used, this is pretty similar to spotify, the youtube mini player, and plex amp. If we were to move them to the item menu, it is still the same number of clicks as going to the full screen player. I'm open to other opinion, but I think that adding the item menu as well makes it a tad too cluttered. If anyone has any other thoughts, I'd be interested to hear them |
@camc314 Maybe I haven't explained myself Wider still: As is right now Maybe the options in narrower are the ones more up for discussion, but imo the stop playback should always be present. I forgot in my PR and it would be nice if it's here instead of the one where I plan to expand more music features: click anywhere in the footer in the layout where there's no full screen button to open full screen music page. |
I agree with @camc314 for this, an item menu is kind of useless since one tap on the footer should bring you to the full screen and then those controls are available. I would even hide the repeat and shuffle on the wider one, honestly, but that's up for discussion. |
I quite like the decisions @camc314 made on these screenshots. I think you could even add the stop playback button even on the narrower screens. And yeah clicking on the footer should put the player to full screen |
Kudos, SonarCloud Quality Gate passed!
|
Changes
Narrowest
![image](https://user-images.githubusercontent.com/18101008/104639813-c03dda80-569f-11eb-9608-c972d31cc52f.png)
Wider
![image](https://user-images.githubusercontent.com/18101008/104639836-c633bb80-569f-11eb-843e-e6ee0e1123e2.png)
Even wider
![image](https://user-images.githubusercontent.com/18101008/104639868-cf248d00-569f-11eb-82e9-92da3ec6ad78.png)
Wider still...