Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(item-menu): use item menu everywhere instead of placeholders #565

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Jan 15, 2021

Partially addresses #557

@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #565 (2e0356c) into master (bbb6cd6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #565   +/-   ##
======================================
  Coverage    5.60%   5.60%           
======================================
  Files          97      97           
  Lines        2696    2696           
  Branches      424     424           
======================================
  Hits          151     151           
  Misses       2538    2538           
  Partials        7       7           
Impacted Files Coverage Δ
components/Item/ItemMenu.vue 0.00% <ø> (ø)
components/Players/TrackList.vue 0.00% <ø> (ø)
pages/item/_itemId/index.vue 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb6cd6...2e0356c. Read the comment docs.

@heyhippari heyhippari mentioned this pull request Jan 15, 2021
16 tasks
@heyhippari heyhippari merged commit 2245858 into master Jan 15, 2021
@heyhippari heyhippari deleted the item-menu branch January 15, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants