fix(norwegian_locale): change the i18n locale.name for nb-NO #567
Conversation
Change the locale name of nb-NO from 'Bokmål' to 'Norsk'
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
======================================
Coverage 5.40% 5.40%
======================================
Files 102 102
Lines 2795 2795
Branches 425 425
======================================
Hits 151 151
Misses 2637 2637
Partials 7 7 Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Shouldn't we add nynorsk as indicated in the linked issue? We might not be able to translate it, but somebody can take the translations over in Weblate. |
| @@ -155,7 +155,7 @@ const config: NuxtConfig = { | |||
| { code: 'en', iso: 'en-US', name: 'English', file: 'en-US.json' }, | |||
| { code: 'es', iso: 'es-ES', name: 'Español (España)', file: 'es.json' }, | |||
| { code: 'fr', iso: 'fr-FR', name: 'Français', file: 'fr-FR.json' }, | |||
| { code: 'nb', iso: 'nb-NO', name: 'Bokmål', file: 'nb_NO.json' }, | |||
| { code: 'nb', iso: 'nb-NO', name: 'Norsk', file: 'nb_NO.json' }, | |||
There was a problem hiding this comment.
| { code: 'nb', iso: 'nb-NO', name: 'Norsk', file: 'nb_NO.json' }, | |
| { code: 'nb', iso: 'nb-NO', name: 'Norsk bokmål', file: 'nb_NO.json' }, |
This is the proper name for it. As there are two variants of "Norsk", we should explicitly mention which one it is.
We'd need to wait until someone on Weblate translates it, then we add it. It's pretty useless to add an empty language just for the sake of it. |
|
Nice 👍 |
Change the locale name of nb-NO from 'Bokmål' to 'Norsk'
Fixes #559