Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: push docker images to ghcr.io alongside DockerHub #795

Merged
merged 2 commits into from
Mar 1, 2021
Merged

chore: push docker images to ghcr.io alongside DockerHub #795

merged 2 commits into from
Mar 1, 2021

Conversation

ferferga
Copy link
Member

@ferferga ferferga commented Feb 25, 2021 •
edited
Loading

Blocked by #767 as it's built on top of it

Pushes Docker images to ghcr.io alongside DockerHub.

Organization-wide changes at jellyfin-archive/jellyfin-metapackages#7

@ferferga ferferga added the blocked Something depends on another issue or Pull Request label Feb 25, 2021
@ferferga ferferga mentioned this pull request Feb 25, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 25, 2021 •
edited
Loading

Codecov Report

Merging #795 (6c6a21d) into master (8ec9276) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   12.09%   12.09%           
=======================================
  Files         136      136           
  Lines        3530     3530           
  Branches      525      525           
=======================================
  Hits          427      427           
  Misses       3080     3080           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec9276...6c6a21d. Read the comment docs.

@ferferga ferferga changed the title chore: push docker images to ghcr chore: push docker images to ghcr.io Feb 25, 2021
@ferferga ferferga changed the title chore: push docker images to ghcr.io chore: push docker images to ghcr.io alongside DockerHub Feb 25, 2021
h1dden-da3m0n
h1dden-da3m0n approved these changes Feb 25, 2021
View reviewed changes
Copy link

@h1dden-da3m0n h1dden-da3m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to have the other comments in this too, ups 😖

.github/workflows/docker.yml Outdated Show resolved Hide resolved
@ferferga ferferga removed the blocked Something depends on another issue or Pull Request label Feb 26, 2021
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Feb 26, 2021
@github-actions github-actions bot added the merge conflict Something has merge conflicts label Mar 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ferferga ferferga removed the merge conflict Something has merge conflicts label Mar 1, 2021
@heyhippari heyhippari merged commit 30188fd into master Mar 1, 2021
@heyhippari heyhippari deleted the ghcr branch March 1, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h1dden-da3m0n h1dden-da3m0n h1dden-da3m0n approved these changes

@ThibaultNocchi ThibaultNocchi ThibaultNocchi approved these changes

@heyhippari heyhippari heyhippari approved these changes

@Shadowghost Shadowghost Awaiting requested review from Shadowghost

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ferferga @ThibaultNocchi @Shadowghost @heyhippari @h1dden-da3m0n