Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare script does not work on Windows #2241

Closed
nielsvanvelzen opened this issue Dec 16, 2020 · 1 comment
Closed

Prepare script does not work on Windows #2241

nielsvanvelzen opened this issue Dec 16, 2020 · 1 comment
Labels
build This PR or issue mainly concerns build tools

Comments

@nielsvanvelzen
Copy link
Member

Yarn will automatically run the prepare task when yarn install is executed without the --no-scripts argument. This is no problem in Posix environments but on Windows it tries to open the .sh file with the editor of preference.
This makes it annoying and bothersome to develop jellyfin-web on Windows.

The simple solution is to not run a platform tied script in the package.json by changing it to a NodeJS script or just remove it entirely.
@nielsvanvelzen nielsvanvelzen added the build This PR or issue mainly concerns build tools label Dec 16, 2020
@thornbill thornbill mentioned this issue Dec 17, 2020
Merged
@thornbill
Copy link
Member

Should be fixed by #2242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build This PR or issue mainly concerns build tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nielsvanvelzen @thornbill