Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bash prepare script with node version #2242

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Replace bash prepare script with node version #2242

merged 1 commit into from
Dec 17, 2020

Conversation

thornbill
Copy link
Member

Changes
Addresses an issue caused by #2080 where the prepare script run on installs was not cross platform.

Issues
#2241

@thornbill thornbill added the stable backport Backport into the next stable release label Dec 17, 2020
@thornbill thornbill added this to Active PRs in Release 10.7.0 via automation Dec 17, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@thornbill thornbill merged commit 898704d into jellyfin:master Dec 17, 2020
Release 10.7.0 automation moved this from Active PRs to Completed PRs Dec 17, 2020
@thornbill thornbill deleted the fix-prepare-script-windows branch December 17, 2020 18:13
@thornbill thornbill mentioned this pull request Dec 18, 2020
Closed
joshuaboniface pushed a commit that referenced this pull request Dec 31, 2020
@thornbill @joshuaboniface
Merge pull request #2242 from thornbill/fix-prepare-script-windows
efe4374 
Replace bash prepare script with node version

(cherry picked from commit 898704d)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Dec 31, 2020
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@ferferga ferferga ferferga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thornbill @nielsvanvelzen @ferferga @joshuaboniface