Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.7.2] No poster images / Low quality card images on high DPI displays #2587

Closed
ottodoesntknow opened this issue Apr 12, 2021 · 7 comments · Fixed by #2593
Closed

[10.7.2] No poster images / Low quality card images on high DPI displays #2587

ottodoesntknow opened this issue Apr 12, 2021 · 7 comments · Fixed by #2593
Labels
bug Something isn't working confirmed The issue has been verified regression We broke something ui & ux This PR or issue mainly concerns UI & UX

Comments

@ottodoesntknow
Copy link

Describe The Bug
Since the last 10.7.2 update I'm seeing low quality images being used for the cards (posters, thumbs and library images). This is a Jellyfin Web issue as I can see them in high quality using Jellyfin Vue.

Steps To Reproduce

  1. Update to 10.7.2
  2. Go to the main page and look at the card images

Expected Behavior
Clear and high quality images being used for the cards.

Screenshots
Jellyfin Web:
image
image
image

Jellyfin Vue:
image
image
image

System (please complete the following information):

  • Platform: Docker 20.10.5 on Ubuntu Server 20.04.2 LTS
  • Browser: Edge Chromium 91.0.845.2 (Dev)
  • Jellyfin Version: 10.7.2 (Hotio Docker image)
@ottodoesntknow ottodoesntknow added the bug Something isn't working label Apr 12, 2021
@oddstr13
Copy link
Member

oddstr13 commented Apr 12, 2021

Could you please provide the URLs of the images?

Edit:
It's probably related to #2514, even if that was supposed to fix this exact issue for other images.
Is this on a High DPI monitor?

@ThibaultNocchi
Copy link
Member

You can get info in #2191

@oddstr13
Copy link
Member

You can get info in #2191

That is not the exact issue at play here, as #2191 is about source images with miss-matching ratio, but the images here look like they have the correct ratio, but are seeing the issue anyways.

@ottodoesntknow
Copy link
Author

ottodoesntknow commented Apr 12, 2021

Could you please provide the URLs of the images?

Movie poster:
http://192.168.0.19:8096/Items/d218622baae752ed2d1018a27bcd170d/Images/Primary?fillHeight=329&fillWidth=219&tag=bdecbcb1690aecb826f5f691e6dc7fa1&quality=90

Thumb:
http://192.168.0.19:8096/Items/c5ba59b06b6a5fdbb04f6377ca44e573/Images/Backdrop?fillWidth=358&tag=995c8bed7de61b4b815aa20940a8f115&quality=80

Library image:
http://192.168.0.19:8096/Items/1dbc59f98f7a5c0db1e7d825102c0336/Images/Primary?fillHeight=201&fillWidth=358&tag=8087f42dcce9f4ee8771832f66777749&quality=90

Edit:
It's probably related to #2514, even if that was supposed to fix this exact issue for other images.
Is this on a High DPI monitor?

Probably. I don't know how to check my exact DPI but I used this site and it gave me this:
image

@yuxincs
Copy link

yuxincs commented Apr 12, 2021

I can confirm the issue with a 4K 27-inch monitor. With the same window size:

URL in 10.7.1:

Items/aafdf1b287b3438d26383b10f8353b5e/Images/Primary?maxHeight=812&maxWidth=542&tag=7c3b29d309eaaad83514d3711b75a6a6&quality=90

URL in 10.7.2:
Items/aafdf1b287b3438d26383b10f8353b5e/Images/Primary?fillHeight=406&fillWidth=270.75&tag=7c3b29d309eaaad83514d3711b75a6a6&quality=90

It seems that Jellyfin-web is unaware of the HiDPI monitor to request the correct height and width.

Also, while resizing the window, I noticed that sometimes the image won't load at all due to invalid width.

For example, the request Items/aafdf1b287b3438d26383b10f8353b5e/Images/Primary?fillHeight=424&fillWidth=282.5&tag=7c3b29d309eaaad83514d3711b75a6a6&quality=90 returns a 400 with the following error message:

{
  "type": "https://tools.ietf.org/html/rfc7231#section-6.5.1",
  "title": "One or more validation errors occurred.",
  "status": 400,
  "traceId": "00-94729ea11d84d448bb0eea0c55182aa1-fedada3a38d15d46-00",
  "errors": {
    "fillWidth": [
      "The value '282.5' is not valid."
    ]
  }
}

I can create another issue if this is unrelated :)

@oddstr13
Copy link
Member

Bleh, jellyfin-archive/jellyfin-apiclient-javascript#167 didn't make it into the release then.

@TheNamelessWonderer
Copy link

@yxwangcs Your issue seems related to this one: jellyfin/jellyfin#5788. Not sure if jellyfin/jellyfin#5788 is related to this issue too.

@oddstr13 oddstr13 changed the title Low quality card images since last 10.7.2 update [10.7.2] No poster images / Low quality card images on high DPI displays Apr 12, 2021
@oddstr13 oddstr13 added confirmed The issue has been verified regression We broke something ui & ux This PR or issue mainly concerns UI & UX labels Apr 12, 2021
@oddstr13 oddstr13 added this to Active Bugs in Release 10.7.0 via automation Apr 12, 2021
Release 10.7.0 automation moved this from Active Bugs to Jellyfinished Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed The issue has been verified regression We broke something ui & ux This PR or issue mainly concerns UI & UX
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Development

Successfully merging a pull request may close this issue.

5 participants