Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary Images fail to load when UI requests non integer scaling #2629

Closed
tlaporte opened this issue Apr 29, 2021 · 2 comments
Closed

Primary Images fail to load when UI requests non integer scaling #2629

tlaporte opened this issue Apr 29, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@tlaporte
Copy link

tlaporte commented Apr 29, 2021

Describe The Bug

Depending on window size, the UI may request primary images scaled to non integer values. In these cases, the request fails due to a validation error.

Steps To Reproduce

  1. In Chrome developer tools, set device emulation to "Responsive", 1549x1236, 100%.
  2. Go to any tv show/movie in your library.
  3. Observe that the primary image is just a blurred placeholder.
  4. In your network log there should be a failed GET request against the server, with an error message like "The value '387.25' is not valid."
  5. If the emulator settings that I used don't work on your machine, it should be reproducible at any resolution where the UI requests a non integer width or height for the image.

I didn't see this with non primary images, but it might be possible.

Expected Behavior

Primary image should load, no network error should appear in the logs.

Perhaps UI should round the width/height scaling values that it requests to the nearest integer.

Logs

Failed GET response:

{
  "type": "https://tools.ietf.org/html/rfc7231#section-6.5.1",
  "title": "One or more validation errors occurred.",
  "status": 400,
  "traceId": "00-249cb87145beda45b076d4962ecaf039-6392203a54514744-00",
  "errors": {
    "fillWidth": [
      "The value '387.25' is not valid."
    ]
  }
}

There are no error logs on the server side.

Screenshots

Screenshot 2021-04-28 202229

System (please complete the following information):

  • Platform: [Windows]
  • Browser: [Firefox, Chrome]
  • Jellyfin Version: [e.g. 10.7.2]
@tlaporte tlaporte added the bug Something isn't working label Apr 29, 2021
@dmitrylyzo
Copy link
Contributor

Should be fixed in next release: jellyfin-archive/jellyfin-apiclient-javascript#167

@cvium
Copy link
Member

cvium commented Apr 29, 2021

Duplicate #2587

@cvium cvium closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants