Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run bump_version in make srpm #3226

Conversation

brianjmurrell
Copy link
Contributor

Changes
Also add an "rpms" target that builds the RPMs using mock in a target
environment.

This applies the same changes to this repo as went into jellyfin/jellyfin@296a61c from jellyfin/jellyfin#6980.

Fix BuildRequires: for RH platforms.

This really wants to be reviewed by @joshuaboniface as some of this is from a jellyfin PR of his. I'm not particularly certain about the bump_version or .ci/ changes so some review there would be useful.

This does produce packages in Copr correctly. I'm just not terribly fluent in the Azure CI stuff.

Signed-off-by: Brian J. Murrell brian@interlinx.bc.ca

Issues
Fixes: #3221

Also add an "rpms" target that builds the RPMs using mock in a target
environment.

Fix BuildRequires: for RH platforms.

Fixes: jellyfin#3221

Signed-off-by: Brian J. Murrell <brian@interlinx.bc.ca>
Copy link
Member

@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

auto-merge was automatically disabled December 14, 2021 14:07

Head branch was pushed to by a user without write access

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@brianjmurrell
Copy link
Contributor Author

This now builds successfully on:

image

@joshuaboniface joshuaboniface merged commit 92cb985 into jellyfin:master Dec 14, 2021
@brianjmurrell brianjmurrell deleted the bmurrell/add-version_bump-to-make-srpm branch December 14, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuildRequires: git missing from fedora/jellyfin.spec
2 participants