-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RPM build for Ci autoversion packages #6980
Update RPM build for Ci autoversion packages #6980
Conversation
Should prevent strangeness with building these for pre-releases or actual release versions. Whatever the Git tag is, becomes the package version.
Avoids breaking Fedora/CentOS while preserving Debian.
Also add an "rpms" target that builds the RPMs using mock in a target environment. Signed-off-by: Brian J. Murrell <brian@interlinx.bc.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the correct way to do it, it's good by me. It's worth mentioning that this should only matter during these particular pre-release builds. "Real" versions will always have the results of bump_version
committed.
Well, it is the way to have your concept of last-minute updating of versions prior to build to work in Copr. To be completely honest, this was just a build upon #6974 and should have only either landed into that PR or after it had approval and landing. Moreover, I was hoping to continue the conversation on why not committing pre-release build information into the source was not a good thing.
Yes, completely understood.
But IMO, the pre-release builds deserve as much transparency as "real" versions. If "real" versions are going to have the |
It's worth noting the addition of the Given that all of this (i.e. package building/release-engineering/devops/CI) is actually what I do in my |
Changes
Update
.copr/Makefile
'ssrpm
target to run the last-minutebump_version
before building the SRPM.As much as I disagree with this approach and think that
bump_version
should be run and then the result of it committed so that the source tree has accurate and transparent versioning, if this approach of last-minute updating is going to go forward (against my advise) then this PR is how to make Copr build an RPM properly versioned.This PR really should be based on https://github.com/joshuaboniface/jellyfin/tree/ci-autoversion-packages but for whatever reason,
joshuaboniface
is not showing up in the base repository selector. As such this PR includes all of the code from #6974. If somebody who can, wants to rebase this on #6974 and land it to there, that is fine. Or this can wait for #6974 to land and then it can be rebased on master and then landed to there.