Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book (epub) do not show sub-entries in the table of contents #4486

Closed
carif opened this issue Apr 10, 2023 · 5 comments · Fixed by #4890
Closed

Book (epub) do not show sub-entries in the table of contents #4486

carif opened this issue Apr 10, 2023 · 5 comments · Fixed by #4890
Labels
bug Something isn't working

Comments

@carif
Copy link
Contributor

carif commented Apr 10, 2023

Describe The Bug
A book in the ePub format can have a hierarchical structure of chapters with sub-chapters etc. Those sub-chapters do not appear in the table of contents view in Jellyfin. Only the top-level chapter's get displayed.
In the screenshot section are some screenshots of an example file to illustrate the problem (Jellyfin vs Calibre). But really, any chapter names and chapter-structure has those problems. I could've move some chapters to the top level and added sub-chapters to them, too, e.g.:

Cover
Made in Abyss 08
- Chapter 01
- Chapter 02
Side Story
- Chapter 01
- Chapter 02

Steps To Reproduce

  1. Go to your book library.
  2. Click on a book to open it. It has to be an ePub file with sub-chapters!
  3. Click on the button for the table of contents.
  4. See error

Expected Behavior
Show a list of all chapters.

Screenshots
The problem:
image
How it should look like (image from calibre):
image

System (please complete the following information):

  • Platform: Fedora Linux
  • Jellyfin + Jellyfin Web Version: 10.8.9
@carif carif added the bug Something isn't working label Apr 10, 2023
@jellyfin-bot
Copy link
Collaborator

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@jellyfin-bot jellyfin-bot added the stale No activity for an extended length of time label Aug 9, 2023
@carif
Copy link
Contributor Author

carif commented Aug 15, 2023

This is still an issue in 10.8.10.

@jellyfin-bot jellyfin-bot removed the stale No activity for an extended length of time label Aug 16, 2023
@vincent
Copy link

vincent commented Oct 18, 2023

How the nested chapters should be displayed ?

I saw some readers flatten the list, making all chapters to appear on top-level.
If they are shown as a tree, should we fear about stupidly-deep nesting ?

Also, atm the font size is recursively bigger, caused by a font-size: 120%

image

@vincent
Copy link

vincent commented Oct 19, 2023

Here is a first proposal, open for any feedback.

image

@carif
Copy link
Contributor Author

carif commented Oct 19, 2023

Here is a first proposal, open for any feedback.

I would probably make the "Chapters" and "Part One" things bold to make it a bit easier on the eyes. I'm not sure what other eBook Readers do here, but Apple makes them bold and the Sections and Sub-sections normal and it looks really nice.

I saw some readers flatten the list, making all chapters to appear on top-level.
If they are shown as a tree, should we fear about stupidly-deep nesting ?

Flattening would be an option, but it would make it harder to understand which sub-chapter relates to which chapter. Regarding the question whether we should fear about studiedly-deep nesting. In theory yes, in practice, all the books I've ever seen go at max to the sub-section depth of your first proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants