-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show nested chapters in bookplayer TOC #4890
Show nested chapters in bookplayer TOC #4890
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
At least with my small test library, I could not identify any problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works in my testing! I just had a quick comment about a potential vulnerability in this code that was pre-existing. 🙂
84e9a91
to
55f5a78
Compare
Kudos, SonarCloud Quality Gate passed!
|
Cloudflare Pages deployment
|
Changes
This PR modify the bookplayer TOC dialog to show nested chapters.
Issues
Fixes #4486