Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show nested chapters in bookplayer TOC #4890

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

vincent
Copy link

@vincent vincent commented Oct 19, 2023

Changes
This PR modify the bookplayer TOC dialog to show nested chapters.

Issues
Fixes #4486

@vincent vincent requested a review from a team as a code owner October 19, 2023 07:48
@vincent
Copy link
Author

vincent commented Oct 20, 2023

Screenshot of the current proposal

image

Copy link
Contributor

@carif carif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
At least with my small test library, I could not identify any problems.

Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works in my testing! I just had a quick comment about a potential vulnerability in this code that was pre-existing. 🙂

src/plugins/bookPlayer/tableOfContents.js Outdated Show resolved Hide resolved
@thornbill thornbill added hacktoberfest-accepted enhancement Improve existing functionality or small fixes labels Nov 3, 2023
@thornbill thornbill added this to the v10.9.0 milestone Nov 8, 2023
@thornbill thornbill force-pushed the bufgix-ebook-toc-nested-chapters branch from 84e9a91 to 55f5a78 Compare November 8, 2023 17:42
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 0a36a97
Status ✅ Deployed!
Preview URL https://fd3a741d.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill merged commit 7df0ffc into jellyfin:master Nov 8, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Book (epub) do not show sub-entries in the table of contents
4 participants