Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix actionSheet #1279

Merged
merged 1 commit into from May 20, 2020
Merged

Fix actionSheet #1279

merged 1 commit into from May 20, 2020

Conversation

dmitrylyzo
Copy link
Contributor

options.items (HTMLOptionsCollection) doesn't have entries function.

Changes
Revert changes to simple loop.

Issues
emby-select isn't clickable in TV layout.

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

@dkanada dkanada merged commit e964709 into jellyfin:master May 20, 2020
@dmitrylyzo dmitrylyzo mentioned this pull request Jul 28, 2020
Merged
@dmitrylyzo dmitrylyzo deleted the fix-actionsheet-1 branch February 20, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmitrylyzo @thornbill @dkanada