Fix issue with sync menu and excessive logging #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
heyhippari
approved these changes
Jul 19, 2020
dmitrylyzo
reviewed
Jul 19, 2020
| @@ -72,7 +72,6 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla | |||
| const now = (new Date).getTime(); | |||
|
|
|||
| if (method !== reportPlaybackLastMethod || now - (reportPlaybackLastTime || 0) >= reportPlaybackLogDelay) { | |||
| console.debug(method + '-' + JSON.stringify(info)); | |||
There was a problem hiding this comment.
This block is for logging. It was more verbose :p
bffafa6
There was a problem hiding this comment.
Ah, well I still think it's way too verbose for the debug logs 😅 might just want to remove it.
thornbill
approved these changes
Jul 23, 2020
|
These also had to be removed: jellyfin-web/src/components/playback/playbackmanager.js Lines 46 to 50 in a8a85df jellyfin-web/src/components/playback/playbackmanager.js Lines 72 to 77 in a8a85df |
Merged
joshuaboniface
pushed a commit
that referenced
this pull request
Jul 27, 2020
Fix issue with sync menu and excessive logging (cherry picked from commit 7c24727) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to get this in 10.6.0 so if someone sees this feel free to review. My chat may or may not be totally broken right now so I'll be gone from Matrix until Tuesday or Wednesday.