Add version check for SyncPlay #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyhippari
force-pushed
the
syncplay-version-check
branch
from
15cd135
to
293a879
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
camc314
approved these changes
Jul 23, 2020
dkanada
approved these changes
Jul 24, 2020
joshuaboniface
pushed a commit
that referenced
this pull request
Jul 27, 2020
Add version check for SyncPlay (cherry picked from commit 03a9e73) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As web (in the context of the Android app, for example) can connect to non 10.6 server, all SyncPlay features should be disabled if the server is not 10.6 or more.
Issues