Fix CircleOfDeath on plugin install #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
approved these changes
Jul 28, 2020
dkanada
approved these changes
Jul 28, 2020
joshuaboniface
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fix CircleOfDeath on plugin install (cherry picked from commit 89e5846) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong initial deminification eb469bd
Form request is
/Packages/Installed/Reports?AssemblyGuid=d4312cd9-5c90-4f38-82e8-51da566790e8&version=7.0.0.0Or should we block downgrade?
But it installs most recent version even if it is uninstalled.
Changes
Fix wrong deminification
Issues
Fixes #1622