Fix fullscreen video in iOS Safari #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
camc314
approved these changes
Jul 29, 2020
anthonylavado
approved these changes
Jul 29, 2020
joshuaboniface
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fix fullscreen video in iOS Safari (cherry picked from commit 9b6a90f) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a regression caused by switching to the screenfull library for fullscreen support. Screenfull does not support iOS because the behavior is non-standard and only works on video elements. We previously had a workaround in place for this, so it is a regression.
Issues
I don't see any logged for this yet...