Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with nowplaying page when item.Album or item.Artists are null. #1686

Merged
merged 3 commits into from
Aug 1, 2020
Merged

Fix issue with nowplaying page when item.Album or item.Artists are null. #1686

merged 3 commits into from
Aug 1, 2020

Conversation

Larvitar
Copy link
Contributor

Fixes two issues:

  1. When one of item.Album and item.Artists was null the other one would not be displayed either.
  2. When item.Album or item.Artists was null query did not return anything and values from previous song would be displayed.

Issues
Fixes #1629

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dkanada dkanada added the stable backport Backport into the next stable release label Jul 31, 2020
@dkanada dkanada merged commit b1aa18e into jellyfin:master Aug 1, 2020
@joshuaboniface joshuaboniface added this to In progress in Release 10.6 Maintenance via automation Aug 3, 2020
@joshuaboniface joshuaboniface moved this from In progress to Done in Release 10.6 Maintenance Aug 3, 2020
joshuaboniface pushed a commit that referenced this pull request Aug 3, 2020
@dkanada @joshuaboniface
Merge pull request #1686 from Larvitar/master
26d29dc 
Fix issue with nowplaying page when item.Album or item.Artists are null.

(cherry picked from commit b1aa18e)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface moved this from Done to Backported in Release 10.6 Maintenance Aug 3, 2020
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Aug 3, 2020
dependabot bot added a commit to iwalton3/jellyfin-web that referenced this pull request Apr 24, 2021
@dependabot
Merge pull request jellyfin#1686 from Larvitar/master
c3d8b60 
Fix issue with nowplaying page when item.Album or item.Artists are null.

(cherry picked from commit b1aa18e)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyhippari heyhippari heyhippari approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.6 Maintenance
  
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[10.6.0] Music nowplaying page is bugging when "Album" tag is empty
4 participants
@Larvitar @heyhippari @dkanada @joshuaboniface