Fix injecting of view with embedded script #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
heyhippari
approved these changes
Aug 2, 2020
dkanada
approved these changes
Aug 2, 2020
|
btw, I dunno why it is silently fails |
|
I'm pretty sure this has been an issue for a while. |
joshuaboniface
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fix injecting of view with embedded script (cherry picked from commit 6607718) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MusicBrainz plugin as example
MusicBrainz plugin fields aren't updated if you open configuration page twice (open, back, open).
That's (probably) because embedded script is still alive when you open page second time, and variable
MusicBrainzPluginConfigis going to be defined second time.https://github.com/jellyfin/jellyfin/blob/b7421db5fea50e684334806a4ecc8d9f943d754a/MediaBrowser.Providers/Plugins/MusicBrainz/Configuration/config.html#L35-L37
Changes
Change injection order: remove, then append.
Issues
Plugin configuration fields aren't updated.