Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto Cast Feature #1909

Merged
merged 4 commits into from Sep 23, 2020
Merged

Add Auto Cast Feature #1909

merged 4 commits into from Sep 23, 2020

Conversation

iwalton3
Copy link
Member

@iwalton3 iwalton3 commented Sep 7, 2020

This adds an "Auto Cast" feature. If you would like to automatically cast to a player such as MPV Shim, you can set it as the default. This will cause the web client to automatically cast to that player on load. The setting is per-browser and is remembered using LocalStorage.

image

Changes

  • Add auto cast feature.
  • Ensure menu is rendered, even before user info is received.
  • Ensure the correct cast info is always displayed.

package.json Outdated Show resolved Hide resolved
@dkanada
Copy link
Member

dkanada commented Sep 15, 2020

The linting issues can be ignored and have been fixed in another pull request.

src/scripts/autocast.js Outdated Show resolved Hide resolved
Copy link
Member

@dkanada dkanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/scripts/autocast.js Outdated Show resolved Hide resolved
src/scripts/libraryMenu.js Outdated Show resolved Hide resolved
src/components/playback/playerSelectionMenu.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.7% 3.7% Duplication

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkanada dkanada merged commit ec44723 into jellyfin:master Sep 23, 2020
@dmitrylyzo dmitrylyzo mentioned this pull request Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants