Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-existing UserData field from requests #2181

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Remove non-existing UserData field from requests #2181

merged 1 commit into from
Dec 6, 2020

Conversation

heyhippari
Copy link
Contributor

Changes

Issues

@heyhippari heyhippari added the stable backport Backport into the next stable release label Dec 5, 2020
@heyhippari heyhippari added this to Active PRs in Release 10.7.0 via automation Dec 5, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.8% 3.8% Duplication

@thornbill
Copy link
Member

@MrTimscampi could you add a description for why this is needed? Thanks!

@crobibero
Copy link
Member

Web is sending a deprecated value for ItemFields, same as from #2103

[2020-12-05 14:26:43.190 +00:00] [WRN] [303] Jellyfin.Api.ModelBinders.CommaDelimitedArrayModelBinder: Error converting value.
System.FormatException: UserData is not a valid value for ItemFields.
 ---> System.ArgumentException: Requested value 'UserData' was not found.
   at System.Enum.TryParseByName(RuntimeType enumType, String originalValueString, ReadOnlySpan`1 value, Boolean ignoreCase, Boolean throwOnFailure, UInt64& result)
   at System.Enum.TryParseInt32Enum(RuntimeType enumType, String originalValueString, ReadOnlySpan`1 value, Int32 minInclusive, Int32 maxInclusive, Boolean ignoreCase, Boolean throwOnFailure, TypeCode type, Int32& result)
   at System.Enum.TryParse(Type enumType, String value, Boolean ignoreCase, Boolean throwOnFailure, Object& result)
   at System.ComponentModel.EnumConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
   --- End of inner exception stack trace ---
   at System.ComponentModel.EnumConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
   at Jellyfin.Api.ModelBinders.CommaDelimitedArrayModelBinder.GetParsedResult(IReadOnlyList`1 values, Type elementType, TypeConverter converter)

@thornbill thornbill merged commit 7cbaa99 into jellyfin:master Dec 6, 2020
Release 10.7.0 automation moved this from Active PRs to Completed PRs Dec 6, 2020
@camc314 camc314 mentioned this pull request Dec 6, 2020
Closed
joshuaboniface pushed a commit that referenced this pull request Dec 14, 2020
@thornbill @joshuaboniface
Merge pull request #2181 from MrTimscampi/no-userdata-field
c4fd94b 
Remove non-existing UserData field from requests

(cherry picked from commit 7cbaa99)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Dec 14, 2020
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Dec 14, 2020
@daullmer daullmer mentioned this pull request Dec 21, 2020
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

@camc314 camc314 camc314 approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@heyhippari @thornbill @crobibero @camc314 @joshuaboniface