New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtitle synchronization on HTML video player #220
Add subtitle synchronization on HTML video player #220
Conversation
I'd prefer if it wasn't a slider and it should be inside the options menu tbh. The current placement is a bit crowded |
I would say it should be inside |
Thanks, I will take the time to test those changes and I will give you some feedback. |
One quick note, I fixed the CI issue here in another PR so you won't have any issues in the future :) The backend changes look good, I agree about moving it out of the main bar though. I would say inside the settings button since that one is for general options. I think the subtitle and audio buttons should stay as track selection. |
40f5301
to
415ec9e
Compare
@redSpoutnik there seem to be a few conflicts but I think this is ready to merge once those are fixed up. |
Ready to put this in as soon as the conflicts are sorted. |
@dkanada @anthonylavado Conflicts merged :) but be aware that I let the "subtitle offset" button in settings, whereas the "subtitle settings" has been removed. |
We'll want to make an issue to track this! |
This PR add the ability to manually set an offset to some subtitles in HTML video player:
Changes
Tested on Linux Mint 18.2 with :
Issues
May partially solve jellyfin/jellyfin#130.