Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonarqube bugs #2213

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Fix sonarqube bugs #2213

merged 1 commit into from
Dec 10, 2020

Conversation

thornbill
Copy link
Member

Changes
Fixes bugs reported in SonarQube causing the scan to fail

Screenshot_2020-12-09 Add a return statement to this callback - jellyfin-web - Jellyfin

Issues
N/A

@thornbill thornbill added the stable backport Backport into the next stable release label Dec 9, 2020
@thornbill thornbill added this to Active PRs in Release 10.7.0 via automation Dec 9, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill merged commit 52543f8 into jellyfin:master Dec 10, 2020
Release 10.7.0 automation moved this from Active PRs to Completed PRs Dec 10, 2020
@thornbill thornbill deleted the fix-sonar-bugs branch December 10, 2020 12:43
@camc314 camc314 mentioned this pull request Dec 10, 2020
Merged
joshuaboniface pushed a commit that referenced this pull request Dec 14, 2020
@thornbill @joshuaboniface
Merge pull request #2213 from thornbill/fix-sonar-bugs
88bb7ad 
Fix sonarqube bugs

(cherry picked from commit 52543f8)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Dec 14, 2020
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

@heyhippari heyhippari heyhippari approved these changes

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thornbill @camc314 @heyhippari @dmitrylyzo @joshuaboniface