Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiplication of event listeners on Live TV pages #2215

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Fix multiplication of event listeners on Live TV pages #2215

merged 1 commit into from
Dec 11, 2020

Conversation

dmitrylyzo
Copy link
Contributor

Changes
Remove unnecessary export.

Issues

  • Multiple menus are displayed on adding EPG (livetvstatus).
  • Multiple Select Path dialogs are displayed (livetvsettings).

How to reproduce

  1. Go to Dashboard / Live TV
  2. Go to Dashboard / DVR
  3. Go to Dashboard / Live TV
  4. Click + (add) next to TV Guide Data Providers -> 2 menus are open
  5. Go to Dashboard / DVR
  6. Click Select Directory next to Default recording path -> 2 dialogs are open

@dmitrylyzo dmitrylyzo added the stable backport Backport into the next stable release label Dec 10, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@dkanada dkanada merged commit 568968f into jellyfin:master Dec 11, 2020
joshuaboniface pushed a commit that referenced this pull request Dec 14, 2020
@dkanada @joshuaboniface
Merge pull request #2215 from dmitrylyzo/fix-livetv-pages
27896bc 
Fix multiplication of event listeners on Live TV pages

(cherry picked from commit 568968f)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Dec 14, 2020
@joshuaboniface joshuaboniface added this to Active PRs in Release 10.7.0 via automation Dec 14, 2020
@joshuaboniface joshuaboniface moved this from Active PRs to Jellyfinished in Release 10.7.0 Dec 14, 2020
@dmitrylyzo dmitrylyzo deleted the fix-livetv-pages branch February 20, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmitrylyzo @thornbill @dkanada @joshuaboniface