Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify some tone mapping related strings #2222

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Modify some tone mapping related strings #2222

merged 1 commit into from
Dec 14, 2020

Conversation

nyanmisaka
Copy link
Member

@nyanmisaka nyanmisaka commented Dec 12, 2020 •
edited
Loading

Changes

  • Set recommand algorithm to Hable. It has better color and contrast.
  • Set recommand tone mapping peak to 100. Avoid incorrect brightness information.
  • All are string changes. I modified it by referring to the translation of the context. If anything is incorrect, please point out.

Server side changes:
jellyfin/jellyfin#4774

@nyanmisaka
Fine tune some tone mapping params
16a30fc 
*Set recommand algorithm to Hable
*Set recommand tone mapping peak to 100
@nyanmisaka nyanmisaka mentioned this pull request Dec 12, 2020
Merged
@nyanmisaka nyanmisaka added this to Active PRs in Release 10.7.0 Dec 12, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@heyhippari heyhippari added the stable backport Backport into the next stable release label Dec 14, 2020
@thornbill thornbill merged commit bb47abc into jellyfin:master Dec 14, 2020
Release 10.7.0 automation moved this from Active PRs to Completed PRs Dec 14, 2020
@nyanmisaka nyanmisaka deleted the finetune-tonemap branch December 14, 2020 15:57
joshuaboniface pushed a commit that referenced this pull request Dec 31, 2020
@thornbill @joshuaboniface
Merge pull request #2222 from nyanmisaka/finetune-tonemap
cd2d30e 
Modify some tone mapping related strings

(cherry picked from commit bb47abc)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Dec 31, 2020
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

@heyhippari heyhippari heyhippari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nyanmisaka @camc314 @heyhippari @thornbill @joshuaboniface