Use Noto Sans from Fontsource #2234
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| @mixin font($weight: null, $size: null) { | ||
| font-family: "Noto Sans", sans-serif; | ||
| font-family: "Noto Sans", "Noto Sans HK", "Noto Sans JP", "Noto Sans KR", "Noto Sans SC", sans-serif; |
There was a problem hiding this comment.
Warning that some of these have conflicting characters (JP and SC, from memory).
Some of the kanji are different between the two scripts, but share the same Unicode number.
There was a problem hiding this comment.
Yeah I found this issue #913 and read through the notes there. I guess we should add a setting to set a hierarchy or preferred character set somewhere. I consider that a 10.8 change though... this should match the current behavior of jellyfin-noto for now.
There was a problem hiding this comment.
KR also has all the Hanja (full characters) in it, so this needs to be set on a per language basis.
There was a problem hiding this comment.
I was thinking we probably shouldn't just rely on the display language since some people may have a larger amount of content in a specific language that is different than their display language. Then they would probably have a preference for which language should be preferred.
This could be done with custom css until a proper preference is added.
|
There are still some vertical alignment issues in TextButton. Especially in mobile safari.
|
|
@nyanmisaka that seems to not be caused by the font itself, but the styles that are being applied. |
Use Noto Sans from Fontsource (cherry picked from commit d66d26b) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Changes
Issues
Fixes the vertical alignment issues of jellyfin-noto (particularly noticeable on buttons and badges)