Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layout issues on mobile item details #2246

Merged
merged 5 commits into from
Dec 21, 2020
Merged

Fix layout issues on mobile item details #2246

merged 5 commits into from
Dec 21, 2020

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Dec 18, 2020 •
edited

Changes
Fixes some of the major layout issues with the item details screen on mobile.

Screen Before After
Movie Portrait Screen Shot 2020-12-18 at 10 07 00 Screen Shot 2020-12-18 at 10 06 56
Movie Landscape Screen Shot 2020-12-18 at 10 07 42 Screen Shot 2020-12-18 at 10 07 33
Actor Portrait Screen Shot 2020-12-18 at 10 19 14 Screen Shot 2020-12-18 at 10 08 02
Album Portrait Screen Shot 2020-12-18 at 10 08 43 Screen Shot 2020-12-18 at 10 08 41
Album Landscape Screen Shot 2020-12-18 at 13 18 59 Screen Shot 2020-12-18 at 13 19 03

Notes:

  • This should probably use a blurhash for the primary image, but it doesn't currently.

Issues
N/A

@thornbill thornbill added the stable backport Backport into the next stable release label Dec 18, 2020
@thornbill thornbill added this to Active PRs in Release 10.7.0 via automation Dec 18, 2020
@thornbill thornbill mentioned this pull request Dec 18, 2020
Closed
42 tasks
@sonarcloud
Copy link

sonarcloud bot commented Dec 18, 2020

SonarCloud Quality Gate failed.

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@Artiume
Copy link
Contributor

Artiume commented Dec 18, 2020

idea killer

@thornbill thornbill merged commit e1672db into jellyfin:master Dec 21, 2020
Release 10.7.0 automation moved this from Active PRs to Completed PRs Dec 21, 2020
@thornbill thornbill deleted the fix-item-details-mobile branch December 21, 2020 19:16
joshuaboniface pushed a commit that referenced this pull request Dec 31, 2020
@thornbill @joshuaboniface
Merge pull request #2246 from thornbill/fix-item-details-mobile
88dc049 
Fix layout issues on mobile item details

(cherry picked from commit e1672db)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Dec 31, 2020
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxr1998 Maxr1998 Maxr1998 approved these changes

@camc314 camc314 camc314 approved these changes

@heyhippari heyhippari heyhippari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thornbill @Artiume @Maxr1998 @camc314 @heyhippari @joshuaboniface