Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chevron centering on home section titles #2260

Merged
merged 2 commits into from
Dec 24, 2020
Merged

Fix chevron centering on home section titles #2260

merged 2 commits into from
Dec 24, 2020

Conversation

thornbill
Copy link
Member

Changes
Fixes the centering issues of the chevron icons in the home section titles

Before:
Screenshot_2020-12-22 Jellyfin

After:
Screenshot_2020-12-22 Jellyfin(1)

Issues
N/A

@thornbill thornbill added the stable backport Backport into the next stable release label Dec 22, 2020
@thornbill thornbill added this to Active PRs in Release 10.7.0 via automation Dec 22, 2020
@nyanmisaka
Copy link
Member

nyanmisaka commented Dec 22, 2020 •
edited

Fixed in home screen but got worse in dashboard.

firefox
image

safari
9106D71C-606C-4843-9F36-20443F2EB491

@thornbill
Copy link
Member Author

👍 good catch

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@thornbill
Copy link
Member Author

Dashboard should be fixed now also.

@dkanada dkanada merged commit af11671 into jellyfin:master Dec 24, 2020
Release 10.7.0 automation moved this from Active PRs to Completed PRs Dec 24, 2020
joshuaboniface pushed a commit that referenced this pull request Dec 31, 2020
@dkanada @joshuaboniface
Merge pull request #2260 from thornbill/moar-centering-issues
3251430 
Fix chevron centering on home section titles

(cherry picked from commit af11671)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Dec 31, 2020
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Dec 31, 2020
@thornbill thornbill deleted the moar-centering-issues branch August 24, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaboniface joshuaboniface joshuaboniface approved these changes

@nyanmisaka nyanmisaka nyanmisaka approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thornbill @nyanmisaka @joshuaboniface @dkanada