Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chromecast error messages to the locales #2290

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Add Chromecast error messages to the locales #2290

merged 1 commit into from
Jan 1, 2021

Conversation

heyhippari
Copy link
Contributor

Changes

Issues

@sonarcloud
Copy link

sonarcloud bot commented Jan 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@thornbill thornbill added the stable backport Backport into the next stable release label Jan 1, 2021
@thornbill thornbill added this to Active PRs in Release 10.7.0 via automation Jan 1, 2021
@thornbill thornbill merged commit a548bef into jellyfin:master Jan 1, 2021
Release 10.7.0 automation moved this from Active PRs to Completed PRs Jan 1, 2021
joshuaboniface pushed a commit that referenced this pull request Jan 23, 2021
@thornbill @joshuaboniface
Merge pull request #2290 from MrTimscampi/chromecast-messages
cde21b3 
Add Chromecast error messages to the locales

(cherry picked from commit a548bef)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Jan 23, 2021
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Jan 23, 2021
@jobhh
Copy link

jobhh commented Jan 23, 2021

Is it by design that MessagePlaybackError does not specify chromecast like the other entry?

@heyhippari
Copy link
Contributor Author

It's what the code currently uses, but that message is only emitted when casting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@heyhippari @jobhh @nielsvanvelzen @camc314 @thornbill @joshuaboniface