Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local version of Noto Sans if available #2312

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Use local version of Noto Sans if available #2312

merged 3 commits into from
Jan 19, 2021

Conversation

jarnedemeulemeester
Copy link
Contributor

Changes
Use the locally installed version of Noto Sans if available instead of downloading it.

Issues

@thornbill
Copy link
Member

This is great!

I needed to add the weight at the end of the font name to get it load the local version though. So instead of "Noto Sans" it needed to be "Noto Sans Regular". We may need to support multiple local names depending on where and how it is installed.

@jarnedemeulemeester
Copy link
Contributor Author

I needed to add the weight at the end of the font name to get it load the local version though. So instead of "Noto Sans" it needed to be "Noto Sans Regular". We may need to support multiple local names depending on where and how it is installed.

Good point, I'll look into it tomorrow!

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jarnedemeulemeester
Copy link
Contributor Author

Tested and working on:

Arch Linux (5.10.4) (Noto Sans installed using noto-fonts package):

  • Chromium 87.0.4280.88
  • Firefox 84.0.1
  • Gnome Web 3.38.2

Windows 10 (2004) (Noto Sans installed from Google Fonts):

  • Google Chrome 87.0.4280.88
  • Microsoft Edge 87.0.664.66
  • Firefox 84.0.2

@thornbill thornbill added the stable backport Backport into the next stable release label Jan 19, 2021
@thornbill thornbill added this to Active PRs in Release 10.7.0 via automation Jan 19, 2021
@thornbill thornbill merged commit 798df9b into jellyfin:master Jan 19, 2021
Release 10.7.0 automation moved this from Active PRs to Completed PRs Jan 19, 2021
@jarnedemeulemeester jarnedemeulemeester deleted the use-local-noto-sans branch January 21, 2021 12:26
joshuaboniface pushed a commit that referenced this pull request Jan 23, 2021
@thornbill @joshuaboniface
Merge pull request #2312 from jarnedemeulemeester/use-local-noto-sans
d27f661 
Use local version of Noto Sans if available

(cherry picked from commit 798df9b)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Jan 23, 2021
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jarnedemeulemeester @thornbill @nielsvanvelzen @joshuaboniface