-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit admin dashboard menu for plugins #2327
Conversation
Some thoughts about UX, which may or may not be valid: Currently all the config pages are in one place only. It's easy to find them since they all end up in the same place. Allowing plugins to add themselves to the menu leads to worse UX, imo, since now plugins can end up wherever (I know the feature is already there, but nothing really used it until now). Furthermore, with the expected plans for the v2 API, plugin pages will be auto-generated from JSON, meaning they'll essentially only be a simple form for configuration. This reduces the utility of this quite a bit, imo. |
This seems like a major regression and severely limits the capabilities of plugins. Can this be an optional feature just used to maybe lower the bar of entry for creating a plugin? Edit: as a side note, if plugins shouldn't be in the official groups that's fine I can remove all grouping in the menu and just keep the plugin header. Either way it looks a lot cleaner with the plugin header alone imo |
The current way plugin pages work is pretty dirty and unsafe (We're taking HTML wholesale, parsing it all and inserting it into the DOM), and relies pretty much entirely on jellyfin-web polluting The idea is to remove the dependency on web. Ultimately, we want the web client to be "just another client". Currently, the server is heavily tied to it and that's an issue. |
Kudos, SonarCloud Quality Gate passed!
|
I don't see any reason to block this right now. It's a marginal improvement to how plugins currently work. When we start planning for a new plugin configuration schema we can decide what features should (or should not) be included. |
Edit admin dashboard menu for plugins (cherry picked from commit 0ff9615) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Changes
I think it would look a little more tidy in the menu if un sorted plugin menu items were under their own section. Also, would like to be able to add plugin items under Live TV(Maybe should allow this for all sections?).
Uhh sorry if its trash code and if you all don't want it thats A-OK 馃槄
Issues