Change babel.config.js sourceType to unamiguous #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
approved these changes
Feb 16, 2021
|
I was able to replicate the issue by removing node_modules, upgrading node, and running an install. Confirmed that this change seems to have fixed the issues in the dashboard. |
dkanada
approved these changes
Feb 17, 2021
joshuaboniface
pushed a commit
that referenced
this pull request
Feb 21, 2021
Change babel.config.js sourceType to unamiguous (cherry picked from commit fee5731) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This should tell Babel to look into each file and treat it as a module or a script This is helpful as some dependencies are moving to TypeScript 2.7 and causing issues in the client.
Letting babel decide on what polyfills to use has had no impact on the client from my limited testing and fixes the below issue.
Issues
Fixes #2405