Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor improvements to plugin pages #2442

Merged
merged 5 commits into from
Mar 6, 2021
Merged

minor improvements to plugin pages #2442

merged 5 commits into from
Mar 6, 2021

Conversation

dkanada
Copy link
Member

@dkanada dkanada commented Feb 23, 2021

  • always selects the newest plugin during installation
  • fix margin and padding for new plugins
  • reduce the number of lines for installed plugin cards
  • fix missing icons for enabling or disabling plugins

@dkanada dkanada added the stable backport Backport into the next stable release label Feb 23, 2021
thornbill
thornbill approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine now. I haven’t tested it to verify it works as expected though.

dkanada and others added 2 commits March 6, 2021 13:41
@dkanada @dmitrylyzo
invert version sorting for plugins
c86306e 
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
@dkanada @dmitrylyzo
select the version at the front of the list instead
90d48d8 
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
@dkanada dkanada requested a review from dmitrylyzo March 6, 2021 04:41
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dkanada dkanada merged commit d149430 into master Mar 6, 2021
@dkanada dkanada deleted the plugin-tweaks branch March 6, 2021 07:17
joshuaboniface pushed a commit that referenced this pull request Mar 6, 2021
@dkanada @joshuaboniface
Merge pull request #2442 from jellyfin/plugin-tweaks
4820158 
minor improvements to plugin pages

(cherry picked from commit d149430)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dkanada @thornbill @dmitrylyzo @joshuaboniface