Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webpack publicPath #2456

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Feb 27, 2021

Error on webOS 1.2 (probably any old WebKit browser):

Automatic publicPath is not supported in this browser

The comment beside:

// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.

Changes
Add empty publicPath.

Issues
webOS 1.2 fails.

No need to backport because 10.7 branch has an older webpack.
But no harm.

@dmitrylyzo dmitrylyzo added p: webos This PR or issue mainly concerns WebOS clients p: tizen This PR or issue mainly concerns Tizen clients labels Feb 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@dkanada dkanada merged commit 6232f1f into jellyfin:master Feb 28, 2021
@dmitrylyzo dmitrylyzo deleted the fix-webpack-publicpath branch February 20, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: tizen This PR or issue mainly concerns Tizen clients p: webos This PR or issue mainly concerns WebOS clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants