browser.js: Avoid misdetecting Chrome OS as OS X #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching for lower-case "os x" not only finds "Mac OS X" but also "CrOS x86_64". Mismatching Chrome OS as Apple device leads to playback issues due to differences in supported client formats.
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
approved these changes
Mar 6, 2021
dkanada
approved these changes
Mar 6, 2021
joshuaboniface
pushed a commit
that referenced
this pull request
Mar 6, 2021
browser.js: Avoid misdetecting Chrome OS as OS X (cherry picked from commit 8d01ed5) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching for lower-case "os x" not only finds "Mac OS X" but also
"CrOS x86_64". Mismatching Chrome OS as Apple device leads to
playback issues due to differences in supported client formats.
I checked User Agent lists on the Internet (e.g. https://developers.whatismybrowser.com/useragents/explore/) and all Apple browsers seem to report "Mac OS X $version" (mac OS) or something similar to "iPhone OS $version like Mac OS X" (iOS device family), so that extended regex should still work.
Fixes #2477