Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 'Remember Me' by default [2.0] #2481

Closed
wants to merge 2 commits into from

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Mar 5, 2021

Better 🤞 alternative to #1952

Requires jellyfin-archive/jellyfin-apiclient-javascript#154

jellyfin/jellyfin-tizen#51 in short (and interpreted):

User has 2 accounts on the server:

  • admin/parent
  • child

Client is on TV (or any shared device).

When you are logging in via manual form, Remember Me is checked by default or restored from localStorage and you have to disable it for admin/parent account each time other user enabled it.

Unset enableAutoLogin is treated as true, so if you have valid AccessToken, app logs in.

When you are logging in via visual form, you cannot turn on/off auto login - its state is taken from previously saved enableAutoLogin, i.e. it may be unexpected for user.

Changes

  • Remember Me is unchecked and not restored - you are presumably starting a new session. And if you want to be remembered you check Remember Me once (in opposite to unchecking it each time).
  • For visual form, Remember Me is always unchecked. If you have no password, you can easily click your card. With password, you must use manual form (switched automatically). If you want to be "remembered", you can still open the manual form and enable the option.

Differences from #1952

  • Being "unremembered", you can now normally open links in a new tab.
  • Refresh doesn't close the session.
  • Chrome and Firefox with Restore previous session enabled will retain the session cookies, and Jellyfin session will be "remembered" regardless of the user's choice.

Issues
Fixes jellyfin/jellyfin-tizen#51

@varlesh also said that Remember Me isn't restored from previous state. So there might be a localStorage issue, but it works on Tizen 4 and 5 (emulator).

@sonarcloud
Copy link

sonarcloud bot commented Mar 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.5% 1.5% Duplication

@github-actions github-actions bot added the merge conflict Conflicts prevent merging label Apr 7, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.9% 0.9% Duplication

@github-actions github-actions bot added merge conflict Conflicts prevent merging and removed merge conflict Conflicts prevent merging labels Apr 11, 2021
@stale
Copy link

stale bot commented Aug 18, 2021

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label. This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale No activity for an extended length of time label Aug 18, 2021
@jellyfin-bot
Copy link
Collaborator

This PR has been closed due to having unresolved merge conflicts.

@jellyfin-bot jellyfin-bot removed the stale No activity for an extended length of time label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Requires work on the web client to finish merge conflict Conflicts prevent merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember me login enabled always by default
2 participants