Disable 'Remember Me' by default [2.0] #2481
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better 🤞 alternative to #1952
Requires jellyfin-archive/jellyfin-apiclient-javascript#154
jellyfin/jellyfin-tizen#51 in short (and interpreted):
User has 2 accounts on the server:
Client is on TV (or any shared device).
When you are logging in via manual form,
Remember Me
is checked by default or restored fromlocalStorage
and you have to disable it for admin/parent account each time other user enabled it.Unset
enableAutoLogin
is treated astrue
, so if you have validAccessToken
, app logs in.When you are logging in via visual form, you cannot turn on/off auto login - its state is taken from previously saved
enableAutoLogin
, i.e. it may be unexpected for user.Changes
Remember Me
is unchecked and not restored - you are presumably starting a new session. And if you want to be remembered you checkRemember Me
once (in opposite to unchecking it each time).Remember Me
is always unchecked. If you have no password, you can easily click your card. With password, you must use manual form (switched automatically). If you want to be "remembered", you can still open the manual form and enable the option.Differences from #1952
Restore previous session
enabled will retain the session cookies, and Jellyfin session will be "remembered" regardless of the user's choice.Issues
Fixes jellyfin/jellyfin-tizen#51
@varlesh also said that
Remember Me
isn't restored from previous state. So there might be alocalStorage
issue, but it works on Tizen 4 and 5 (emulator).