Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix music videos on artist and album page #2572

Merged
merged 1 commit into from Apr 9, 2021
Merged

Fix music videos on artist and album page #2572

merged 1 commit into from Apr 9, 2021

Conversation

daullmer
Copy link
Member

@daullmer daullmer commented Apr 9, 2021

Changes
Album detail page:

  • Use correct query selector for music video content

Artist detail page:

  • Use ArtistIds instead of AlbumArtistIds as described in issue
  • Use correct card shape for music videos

Issues
Fixes jellyfin/jellyfin#5156

@daullmer
Copy link
Member Author

daullmer commented Apr 9, 2021

Maybe we can backport this to 10.7?

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
33.3% 33.3% Duplication

@thornbill thornbill added this to Active PRs in Release 10.7.0 via automation Apr 9, 2021
@thornbill thornbill added the stable backport Backport into the next stable release label Apr 9, 2021
@thornbill thornbill merged commit e813fa7 into jellyfin:master Apr 9, 2021
Release 10.7.0 automation moved this from Active PRs to Completed PRs Apr 9, 2021
@daullmer daullmer deleted the music_video_fix branch April 9, 2021 17:17
joshuaboniface pushed a commit that referenced this pull request Apr 11, 2021
@thornbill @joshuaboniface
Merge pull request #2572 from Ullmie02/music_video_fix
32d1521 
Fix music videos on artist and album page

(cherry picked from commit e813fa7)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Apr 11, 2021
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyhippari heyhippari heyhippari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API returns an empty array for music videos related to an artist or album
4 participants
@daullmer @heyhippari @thornbill @joshuaboniface