Fix Thumb rendering without thumbnails #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPandemic
changed the title
cvium
approved these changes
Apr 22, 2019
|
I didn't every possible combinations, but for the one I tried, they seemed to be working well. |
dkanada
approved these changes
Apr 23, 2019
Bond-009
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The initial problem was occurring when rendering a page in
Thumb(options.cardLayout = false) mode and the media didn't have a thumbnail (forceName = true). In this specific situation, it would try to render the title in theinnerCardFooterrather than in theouterCardFooter. Those footers would render the title in a<button>, but theinnerCardFooterwas already rendered in a<button>. This double<button>was breaking the browser's HTML renderers.This fix prevents the usage of
innerCardFooterand fallbacks toouterCardFooter.Before:
After (you can see it also fixed the title positioning):
Issues
Closes #228