Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double click to fullscreen #275

Merged
merged 2 commits into from Apr 30, 2019
Merged

Add double click to fullscreen #275

merged 2 commits into from Apr 30, 2019

Conversation

DrPandemic
Copy link
Contributor

Changes
Double click to fullscreen.

Issues
Closes #198

@anthonylavado anthonylavado added this to To Do in Release 10.4.0 via automation Apr 25, 2019
@anthonylavado anthonylavado requested a review from a team April 26, 2019 04:47
@joshuaboniface joshuaboniface requested a review from a team April 26, 2019 04:56
Release 10.4.0 automation moved this from To Do to To Merge Apr 26, 2019
src/controllers/videoosd.js Outdated Show resolved Hide resolved
Copy link
Member

@dkanada dkanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new changes broke the linter

Co-Authored-By: DrPandemic <DrPandemic@users.noreply.github.com>
@DrPandemic
Copy link
Contributor Author

I didn't look at the result after accepting the modification on Github... Should be fixed

@anthonylavado anthonylavado dismissed dkanada’s stale review April 30, 2019 03:58

The error from the linter has been fixed

@anthonylavado anthonylavado merged commit 575cf4f into jellyfin:master Apr 30, 2019
Release 10.4.0 automation moved this from To Merge to Done Apr 30, 2019
@DrPandemic DrPandemic deleted the double-click-to-fullscreen branch April 30, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fullscreen on doubleclick
5 participants