Fix some issues with the user preference page #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonylavado
approved these changes
Apr 30, 2019
joshuaboniface
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EnableAutoLogin field is only used when there is one user on the server and they have a blank password, but I don't think this should be a feature. This does not break the client auto login, so after logging in once they will stay logged in just like any other service. It only removes the weird functionality that didn't even require clicking a user profile once.
There were also some issues with editing another user's preferences from the dashboard from this page, which I also resolved here. The
userandadminsections should be hidden since those aren't related, and the username should get updated to the user currently getting edited.