Update apiclient #3001
Merged
Update apiclient #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
approved these changes
Sep 24, 2021
dmitrylyzo
requested changes
Sep 25, 2021
There was a problem hiding this comment.
Now I'm thinking, What was I testing then? 😅
Because of this babel doesn't use specified targets in the browserlist - there is let in the dist.
UPD:
As an option (so as not to re-publish), we could add the apiclient to the web's babel:
--- a/webpack.common.js
+++ b/webpack.common.js
@@ -92,7 +92,7 @@ module.exports = {
},
{
test: /\.(js|jsx)$/,
- exclude: /node_modules[\\/](?!@uupaa[\\/]dynamic-import-polyfill|blurhash|date-fns|epubjs|flv.js|libarchive.js)/,
+ exclude: /node_modules[\\/](?!@uupaa[\\/]dynamic-import-polyfill|blurhash|date-fns|epubjs|flv.js|jellyfin-apiclient|libarchive.js)/,
use: [{
loader: 'babel-loader'
}]
|
We should fix the apiclient and publish a new version imho. I opened a PR to fix it here: jellyfin-archive/jellyfin-apiclient-javascript#304. |
thornbill
force-pushed
the
bump-apiclient
branch
from
a8ae036
to
4aeb9b6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dmitrylyzo
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bumps the apiclient to the latest release
Issues
Fixes #2909