Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dialog buttons smaller on TV #3069

Merged
merged 1 commit into from Oct 16, 2021
Merged

Make dialog buttons smaller on TV #3069

merged 1 commit into from Oct 16, 2021

Conversation

dmitrylyzo
Copy link
Contributor

In #1222, the buttons were changed for Desktop and Mobile, but were left "as is" for the TV layout.

Before After
before after
before2 after2
before3 after3
We may have a problem with Samsung because the active button is hard to distinguish from the inactive one.
before4 after4

Changes
Make dialog buttons smaller on TV

Issues
Fixes #3030

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@thornbill thornbill merged commit 3e98edc into jellyfin:master Oct 16, 2021
@dmitrylyzo dmitrylyzo deleted the smaller-tv-buttons branch October 20, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ugly modal dialogs in TV layout
2 participants
@dmitrylyzo @thornbill