Convert edit user page to react #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this will need rebased since your other PR has been merged. |
grafixeyehero
force-pushed
the
convert-editUserPage-to-react
branch
from
47c7a92
to
f4d9d7a
Compare
This is my first rebase |
grafixeyehero
force-pushed
the
convert-editUserPage-to-react
branch
from
f4d9d7a
to
192b754
Compare
thornbill
requested changes
Nov 18, 2021
grafixeyehero
force-pushed
the
convert-editUserPage-to-react
branch
from
1a66afa
to
3c32e87
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
requested changes
Dec 30, 2021
There was a problem hiding this comment.
In addition to the one comment here, I noticed a few issues when testing.
- Tabs are not styled correctly when on the "Profile" tab
- Spacing seems a bit tighter than it was previously particularly in the checkbox lists
- The section for allowing media deletion has some issues
- All libraries checkbox should be included in list of libraries
DeleteFoldersAccessandDeleteFoldersAccessHelpsections should be removed
grafixeyehero
force-pushed
the
convert-editUserPage-to-react
branch
from
15209be
to
21d493c
Compare
grafixeyehero
force-pushed
the
convert-editUserPage-to-react
branch
from
21d493c
to
b22a9ed
Compare
Fix Spacing for checkbox lists
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on convert NewUserPage to react #3026