Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin image URL #3146

Merged
merged 1 commit into from Nov 5, 2021
Merged

Fix plugin image URL #3146

merged 1 commit into from Nov 5, 2021

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Nov 5, 2021

Changes
Use ApiClient.getUrl to generate the correct URL for the plugin image.

Issues
Fixes #3145

Theoretically, this is backportable to 10.7 (cherry-pick works).

@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill merged commit 832a204 into master Nov 5, 2021
@thornbill thornbill deleted the fix-plugin-image branch November 5, 2021 20:38
@RamonEbdon
Copy link

Nice work, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin dashboard Plugins page images do not load when 'BaseUrl' is set
3 participants