Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emptyImageElement
is called twice.The first call moves
background
todata-src
.The second call empties
data-src
.jellyfin-web/src/components/images/imageLoader.js
Line 111 in 832a204
This can happen because of repeated animation frame request for the same element.
jellyfin-web/src/components/images/imageLoader.js
Lines 70 to 72 in 832a204
Changes
Fix re-emptying image
Issues
Fixes #3140
Alternatively, we could collect the affected elements into an array and request the animation frame once.
https://github.com/dmitrylyzo/jellyfin-web/tree/fix-genre-image-2