Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback hls.js to 0.14 #3161

Merged
merged 1 commit into from Nov 11, 2021
Merged

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Nov 10, 2021

Changes
This rollsback hls.js to 0.14 and prevents dependabot from opening PRs for major version upgrades due to this upstream issue: video-dev/hls.js#4367

Issues
Fixes #3158

@thornbill thornbill requested a review from a team as a code owner November 10, 2021 21:21
@thornbill thornbill added this to Active PRs in Release 10.8.0 via automation Nov 10, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ccheng32
Copy link

Hi @thornbill thanks for the fix. Have you verified that hls.js v0.14.7 fixes #3158?

AFAIK I encountered the problem on an unmodified jellyfin server running v10.7.7, which seems to serve hls.js v0.14.17 for the web frontend. (link)

@ccheng32
Copy link

Some more updates from my testing. I acutally tried out some more browsers and found out that Chrome and Firefox have this issue, while Safari on MacOS does not have this issue at all. I suspect this line may be the culprit:

if ((browser.chrome || browser.edgeChromium || browser.firefox) && playbackManager.getMaxStreamingBitrate(this) >= 25000000) {

@ThibaultNocchi
Copy link
Member

ThibaultNocchi commented Nov 11, 2021

Safari does handle HLS natively, and I think the client takes profit of it. @thornbill could confirm, but I guess it's why there's no problem with Safari.

Also the line you've found hasn't been touched since 10.7.7, so if it worked back then and not now it's not due to that. Could you please retry with 10.7.7? :)

From experience, with HLS.js >= 1 it happens really quickly in any playback. Maybe it happened back then, but we'd have heard about it if such a bug was present in production.

Release 10.8.0 automation moved this from Active PRs to Approved PRs Nov 11, 2021
@crobibero crobibero merged commit 378b437 into jellyfin:master Nov 11, 2021
Release 10.8.0 automation moved this from Approved PRs to Completed PRs Nov 11, 2021
@thornbill
Copy link
Member Author

I did not see any errors in Firefox, but I didn't test it too thoroughly either. 😅

@thornbill thornbill deleted the rollback-hlsjs branch March 29, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 10.8.0
  
Completed PRs
Development

Successfully merging this pull request may close these issues.

Cannot seek/rewind videos that require transcoding (bufferSeekOverHole error from hls.js)
4 participants