Fix CI package building #3238
Closed
Fix CI package building #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjmurrell
requested review from
joshuaboniface,
dkanada and
EraYaN
as code owners
brianjmurrell
force-pushed
the
bmurrell/fix-ci-builds
branch
from
906ced4
to
d877211
Compare
|
I spent some time looking at the build issues today and came up with this: #3246 |
brianjmurrell
force-pushed
the
bmurrell/fix-ci-builds
branch
from
04dcf27
to
e59f798
Compare
brianjmurrell
force-pushed
the
bmurrell/fix-ci-builds
branch
2 times, most recently
from
662bfc7
to
7e0638f
Compare
Build packages as a non-root user. Build pckages on a pull request to ensure packaging regressions get identified before landing. Reduce package installation to only what is necessary to build the source. Use more natural booleans in shell scripts. Add datestamp to the Release: for unstable builds instead of mangling up the version. Move ARG processing in Dockerfiles to the end of the file so that a simple change in an ARG value does not cause O/S installation/upgrade layers to be repeated. Signed-off-by: Brian J. Murrell <brian@interlinx.bc.ca>
brianjmurrell
force-pushed
the
bmurrell/fix-ci-builds
branch
from
7e0638f
to
c0a3a59
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This PR has been closed due to having unresolved merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes CI package building.